Properly type bbox and datetime#490
Merged
vincentsarago merged 6 commits intostac-utils:mainfrom Apr 9, 2024
Merged
Conversation
carderne
force-pushed
the
master
branch
3 times, most recently
from
644d271 to
f2158df
Compare
Collaborator
|
Hi @carderne. This is pr is pretty old now. Do you remember why it was never moved from Draft? It would be nice to add this work to the project as it looks really good. Thanks! |
Contributor
Author
|
Hmm... I can't remember! It was part of the work described in this comment #477 (comment) (this PR is points 1+2 from that comment). I'm not using stac-fastapi much right now but happy to get this PR over the line if you think useful! |
Contributor
Author
|
This should be ready for review now... |
Collaborator
|
Hi @carderne thank you! I will review this when I get home in a few days. |
jonhealy1
approved these changes
Apr 5, 2024
Collaborator
jonhealy1
left a comment
jonhealy1
left a comment
There was a problem hiding this comment.
Looks great! Thank you.
vincentsarago
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
This PR comment: #477 (comment)
Description:
WIP
PR Checklist:
pre-commit run --all-files)make test)make docs)